[MGNLDIFF-22] NPE occures when I open a a workitem, which was removed before Created: 28/Sep/12  Updated: 19/Oct/12  Resolved: 19/Oct/12

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 1.1.2
Fix Version/s: 1.1.3

Type: Bug Priority: Minor
Reporter: Frank Sommer Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File MGNLDIFF-22-fix-NPE.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

If a publisher want to open a workitem which another publisher has already proceeded, a NullPointerException will occure and the following stacktrace will be shown. In stacktrace you can see, that the diff module causes this exception.

java.lang.RuntimeException: java.lang.NullPointerException
	info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:165)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
...
root cause
java.lang.NullPointerException
	info.magnolia.module.diff.dialog.DiffLink.drawHtml(DiffLink.java:66)
	info.magnolia.cms.gui.dialog.DialogControlImpl.drawSubs(DialogControlImpl.java:323)
	info.magnolia.cms.gui.dialog.DialogControlImpl.drawHtml(DialogControlImpl.java:167)
	info.magnolia.cms.gui.dialog.DialogControlImpl.drawSubs(DialogControlImpl.java:323)


 Comments   
Comment by Milan Divilek [ 09/Oct/12 ]

Hello Frank,

thanks for reporting. Issue will be fixed in nearest bugfix release.

Milan

Comment by Jan Haderka [ 19/Oct/12 ]

missing test

Generated at Mon Feb 12 05:20:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.