[MGNLDIFF-25] Add diff support for versioned templates Created: 14/Jan/13  Updated: 10/Jun/13  Resolved: 15/Feb/13

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 1.1.3
Fix Version/s: 1.1.4

Type: New Feature Priority: Neutral
Reporter: Jan Haderka Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLINTEMPL-26 Add diff support for versioned templates Closed
relation
is related to MGNLRES-61 Extending the implementation of the d... Closed
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:

 Description   

See details at http://www.java.net/blog/rah003/archive/2013/01/22/diff-versioned-templates-magnolia



 Comments   
Comment by Tobias Mattsson [ 12/Feb/13 ]

Notes from review:

VersionDiffHtmlServlet

  • the javadoc on the class itself refers to request parameters that are incorrect
  • the javadoc of getSourceUrl says that it will return the url with request parameters for username etc but those are added elsewhere
  • in the text of the diff view there are missing spaces, for instance: "arenot"
  • it might make sense to make the view into a ftl
Generated at Mon Feb 12 05:20:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.