[MGNLDIFF-27] Diff Module breaks install of Demo project Created: 12/Feb/13  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 1.1.4
Fix Version/s: 1.x

Type: Bug Priority: Major
Reporter: Tobias Mattsson Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

I checked out 4.5.x branch (4.5.8-SNAPSHOT) and added:

    <dependency>
      <groupId>info.magnolia</groupId>
      <artifactId>magnolia-demo-project</artifactId>
      <version>2.0.9-SNAPSHOT</version>
    </dependency>
    <dependency>
      <groupId>info.magnolia</groupId>
      <artifactId>magnolia-module-inplace-templating</artifactId>;
      <version>1.3.3-SNAPSHOT</version>
    </dependency>
    <dependency>
      <groupId>info.magnolia</groupId>
      <artifactId>magnolia-module-diff</artifactId>
      <version>1.1.4-SNAPSHOT</version>
    </dependency>

It fails on installing demo-project, in RepositoryBackedSecurityManager:193

nodeID = SecuritySupport.Factory.getInstance().getGroupManager().getGroup(resourceName).getId();

The group 'editors' doesnt exist. If I leave out diff it works, with diff 1.1.3 it fails too.

The node for the editors group doesnt exist, returns null in info.magnolia.cms.security.MgnlGroupManager#getGroup line 95

    @Override
    public Group getGroup(final String name) throws AccessDeniedException {
        return MgnlContext.doInSystemContext(new SilentSessionOp<Group>(getRepositoryName()) {

            @Override
            public Group doExec(Session session) throws RepositoryException {
                if (!session.itemExists("/" + name)){
                    return null;
                }
                Node groupNode = session.getNode("/" + name);
                return newGroupInstance(groupNode);
            }

            @Override
            public String toString() {
                return "get group " + name;
            }
        });
    }


 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 05:20:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.