[MGNLDIFF-29] Magnolia diff module to support custom session cookie name Created: 23/May/13  Updated: 01/Aug/13  Resolved: 10/Jun/13

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 1.1.4
Fix Version/s: 1.1.5

Type: Improvement Priority: Major
Reporter: Tomas Brimor Assignee: Jaroslav Simak
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
documentation
to be documented by DOCU-442 Diff module configuration Closed
duplicate
duplicates MGNLDIFF-30 Make the diff module configurable Closed
supersession
is superseded by MGNLDIFF-30 Make the diff module configurable Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Currently it is not possible to compare e.g. web site nodes (using the versions view) if you have a custom session cookie name.

The value is hardcoded in info.magnolia.module.diff.VersionDiffHtmlServlet to look for a cookie name COOKIE_SESSION_ID = "JSESSIONID". If you have your session cooke name set to anything else you will get a NPE:

java.lang.RuntimeException: java.lang.NullPointerException
	info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:165)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.i18n.I18nContentSupportFilter.doFilter(I18nContentSupportFilter.java:76)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.RangeSupportFilter.doFilter(RangeSupportFilter.java:84)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.security.BaseSecurityFilter.doFilter(BaseSecurityFilter.java:60)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.security.SecurityCallbackFilter.doFilter(SecurityCallbackFilter.java:86)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.security.LogoutFilter.doFilter(LogoutFilter.java:93)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.templatingkit.filters.SiteMergeFilter.doFilter(SiteMergeFilter.java:99)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.extendedtemplatingkit.filters.MultiSiteFilter.doFilter(MultiSiteFilter.java:100)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MultiChannelFilter.doFilter(MultiChannelFilter.java:83)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.cache.filter.GZipFilter.doFilter(GZipFilter.java:75)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:93)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.enterprise.registration.RegistrationFilter.doFilter(RegistrationFilter.java:52)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.CosMultipartRequestFilter.doFilter(CosMultipartRequestFilter.java:91)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.devicedetection.filter.DeviceDetectionFilter.doFilter(DeviceDetectionFilter.java:73)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:102)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.ContextFilter.doFilter(ContextFilter.java:131)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:67)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.SafeDestroyMgnlFilterWrapper.doFilter(SafeDestroyMgnlFilterWrapper.java:108)
	info.magnolia.cms.filters.MgnlFilterDispatcher.doDispatch(MgnlFilterDispatcher.java:67)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:108)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:94)

root cause

java.lang.NullPointerException
	info.magnolia.module.diff.VersionDiffHtmlServlet.getVersionSource(VersionDiffHtmlServlet.java:235)
	info.magnolia.module.diff.VersionDiffHtmlServlet.getVersionDiffHtml(VersionDiffHtmlServlet.java:221)
	info.magnolia.module.diff.VersionDiffHtmlServlet.doGet(VersionDiffHtmlServlet.java:111)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
	info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:123)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:67)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.debug.DumpHeadersFilter.doFilter(DumpHeadersFilter.java:82)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.VirtualUriFilter.doFilter(VirtualUriFilter.java:70)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.cache.executor.Bypass.processCacheRequest(Bypass.java:58)
	info.magnolia.module.cache.executor.CompositeExecutor.processCacheRequest(CompositeExecutor.java:66)
	info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:153)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.i18n.I18nContentSupportFilter.doFilter(I18nContentSupportFilter.java:76)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.RangeSupportFilter.doFilter(RangeSupportFilter.java:84)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.security.BaseSecurityFilter.doFilter(BaseSecurityFilter.java:60)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.security.SecurityCallbackFilter.doFilter(SecurityCallbackFilter.java:86)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.security.LogoutFilter.doFilter(LogoutFilter.java:93)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.templatingkit.filters.SiteMergeFilter.doFilter(SiteMergeFilter.java:99)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.extendedtemplatingkit.filters.MultiSiteFilter.doFilter(MultiSiteFilter.java:100)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MultiChannelFilter.doFilter(MultiChannelFilter.java:83)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.cache.filter.GZipFilter.doFilter(GZipFilter.java:75)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:93)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.enterprise.registration.RegistrationFilter.doFilter(RegistrationFilter.java:52)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
	info.magnolia.cms.filters.CosMultipartRequestFilter.doFilter(CosMultipartRequestFilter.java:91)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.module.devicedetection.filter.DeviceDetectionFilter.doFilter(DeviceDetectionFilter.java:73)
	info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:102)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.ContextFilter.doFilter(ContextFilter.java:131)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
	info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:67)
	info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
	info.magnolia.cms.filters.SafeDestroyMgnlFilterWrapper.doFilter(SafeDestroyMgnlFilterWrapper.java:108)
	info.magnolia.cms.filters.MgnlFilterDispatcher.doDispatch(MgnlFilterDispatcher.java:67)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:108)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:94)


 Comments   
Comment by Jaroslav Simak [ 10/Jun/13 ]

Resolved as duplicate - this was fixed in MGNLDIFF-30.

Generated at Mon Feb 12 05:20:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.