[MGNLDIFF-32] Original host/port is used instead that which is declared in configuration Created: 20/Jun/13  Updated: 29/Jul/13  Resolved: 26/Jul/13

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 1.1.5
Fix Version/s: 1.2

Type: Bug Priority: Neutral
Reporter: Milan Divilek Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File VersionDiffHtmlServlet.patch    
Issue Links:
relation
is related to MGNLDIFF-30 Make the diff module configurable Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

MGNLDIFF-30 brings possibility to define own host/port, but the original one is still used.

Problematic instruction is in method info.magnolia.module.diff.VersionDiffHtmlServlet.setHostConfiguration(HttpClient, String) on line 297

relUrl = url;


 Comments   
Comment by Jan Haderka [ 08/Jul/13 ]

test?

Comment by Jaroslav Simak [ 22/Jul/13 ]

Can't test because of this code:

            HttpClient client = new HttpClient();
            url = setHostConfiguration(client, url);
            GetMethod getMethod = new GetMethod(url + getParameterString(version));
            getMethod = setCookies(getMethod, request);
            getMethod = setHeaders(getMethod, request);
            client.executeMethod(getMethod);

Method in which this code resides cannot be rewritten because of private visibility.

Comment by Roman Kovařík [ 23/Jul/13 ]

commits:
https://git.magnolia-cms.com/gitweb/?p=enterprise%2Fdiff.git&a=search&h=HEAD&st=commit&s=MGNLDIFF-32

Generated at Mon Feb 12 05:20:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.