[MGNLDIFF-65] i18n: Compare versions actions need to be i18n-ized Created: 12/Nov/13  Updated: 21/Nov/13  Resolved: 13/Nov/13

Status: Closed
Project: Magnolia Diff Module
Component/s: None
Affects Version/s: 1.4
Fix Version/s: 1.5

Type: Bug Priority: Major
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLDIFF-62 i18n: Create a german translation fo... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.2-rc2

 Description   

i18n: remove hardcoded strings from „Compare versions“ , „Compare to previous version“
in bootstraps

  • diff/src/main/resources/mgnl-bootstrap/diff/config.modules.pages.apps.pages.subApps.browser.actions.compareToPreviousVersion.xml
  • diff/src/main/resources/mgnl-bootstrap/diff/config.modules.pages.apps.pages.subApps.browser.actions.compareVersions.xml

add the texts to the bundle diff/src/main/resources/mgnl-i18n/module-diff-messages_en.properties



 Comments   
Comment by Christoph Meier [ 13/Nov/13 ]

It is sufficient just to remove the labels from the bootstrap; afterward texts already in the bundle are used.
But for sure it requires a version-Hanlder-task.

Comment by Christoph Meier [ 13/Nov/13 ]

committed onto branch MGNLDIFF-65

Comment by Christoph Meier [ 13/Nov/13 ]

committed onto master

Comment by Philip Mundt [ 21/Nov/13 ]

There's no test for the ModuleVersionHandler.

Generated at Mon Feb 12 05:21:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.