[MGNLDIFF-8] bundled daisy diff jar should not include third party classes Created: 03/Dec/10 Updated: 27/Sep/11 Resolved: 12/Apr/11 |
|
| Status: | Closed |
| Project: | Magnolia Diff Module |
| Component/s: | None |
| Affects Version/s: | 1.0 |
| Fix Version/s: | 1.0.3 |
| Type: | Task | Priority: | Blocker |
| Reporter: | Philipp Bärfuss | Assignee: | Daniel Lipp |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Comments |
| Comment by Philipp Bärfuss [ 03/Dec/10 ] |
|
|
| Comment by Jan Haderka [ 03/Dec/10 ] |
|
discussion about de-coupling and upload to central repo: http://groups.google.com/group/daisydiff/browse_thread/thread/d7f76bee49712941?hl=en |
| Comment by Daniel Lipp [ 11/Apr/11 ] |
|
Checked out sources for v1.1 (http://daisydiff.googlecode.com/svn/tags/v1.1/), adapted build.xml to not include nekohtml.jar (1.9.11), xercesImpl-2.8.0.jar and eclipse-core-runtime-20070801.jar, then run the ant-build. |
| Comment by Daniel Lipp [ 11/Apr/11 ] |
|
the third-party jar's that we had to explicitely exclude from the daisydiff jar |
| Comment by Daniel Lipp [ 11/Apr/11 ] |
|
the daisydiff jar containing all for v1.1 except the thirdparty jars |
| Comment by Magnolia International [ 11/Apr/11 ] |
|
Added two artifacts to our thirdparty.customized repository: <dependency> <groupId>org.outerj</groupId> <artifactId>daisydiff</artifactId> <version>1.1-magnolia</version> <classifier>nothirdparty</classifier> </dependency> <dependency> <groupId>org.eclipse.core</groupId> <artifactId>eclipse-core-runtime</artifactId> <version>2007081-for-daisydiff</version> </dependency> A basic unit test in this module would help validating the necessary classes/dependencies are there ! |
| Comment by Daniel Lipp [ 12/Apr/11 ] |
|
manually created daisy diff jar not containing thirdparty stuff and use it in pom of diff-module |