[MGNLDIFF-82] i18n aware comparison doesn't work in multisite environment Created: 23/Dec/14 Updated: 12/Jan/15 Resolved: 05/Jan/15 |
|
| Status: | Closed |
| Project: | Magnolia Diff Module |
| Component/s: | None |
| Affects Version/s: | 1.6.1 |
| Fix Version/s: | 1.6.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Zarko Ivanoski | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Visible to: |
Marcel Stör
|
||||||||||||||||||||||||
| Description |
|
This feature was implemented with The problem is that VersionDiffHtmlServlet#getVersionSource is generating the default language url (english) rather than the correct url for the locale - one that is prefixed with the locale - (just 'handle' instead of '/fr/handle'). This happens because i18nContentSupport.toI18NURI(NodeUtil.getPathIfPossible(Node)) is returning the wrong URL - and this is because the actual site is not set on the AggregationState and so AbstractI18nContentSupport.isLocaleSupported() returns false for French. Because French is indeed not in the Locale}}s collection for the {{default site! Suggested solutionPut correct Site on the AggregationState in VersionDiffHTMLServlet. To Reproduce
|
| Comments |
| Comment by Philip Mundt [ 23/Dec/14 ] |
|
|
| Comment by Philip Mundt [ 05/Jan/15 ] |
|
There is an issue with the comparison when the Locale definition specifies a country, i.e. fr_CH won't work. |