[MGNLDIFF-88] IE Conditional comments breaks the diff Created: 21/May/15 Updated: 14/Nov/16 Resolved: 24/May/16 |
|
| Status: | Closed |
| Project: | Magnolia Diff Module |
| Component/s: | None |
| Affects Version/s: | 1.6.2, 1.7.1 |
| Fix Version/s: | 1.7.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Benoit Olbrechts | Assignee: | Maxime Michel |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | 1d 3h | ||
| Time Spent: | 5h | ||
| Original Estimate: | 2d | ||
| Environment: |
Chrome 42.0.2311.135 |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Date of First Response: | |||||||||
| Visible to: |
Benoit Poncelet, Hugo Venancio
|
||||||||
| Sprint: | Sprint 3 (Vietnam), Sprint 4 (Basel), Basel 45 | ||||||||
| Story Points: | 2 | ||||||||
| Description |
|
Having IE conditional comments before the <head> in the main template breaks the show diff functionality. This can lead to resources not loaded by being still part of the non closed comment. Find a sample script attached and resulting html attached. |
| Comments |
| Comment by Sang Ngo Huu [ 28/Jul/15 ] |
|
I tried the template as attached on Chrome, IE 9,11 but diff module still works fine (See screenshot ). |
| Comment by Federico Grilli [ 06/Aug/15 ] |
|
We tried to reproduce the issue also during review and QA (using both the affected version in Magnolia bundle 5.3.7 and latest 5.3.11-SNAPSHOT) but all looked fine. |
| Comment by Richard Gange [ 20/Apr/16 ] |
|
We have another report of this issue with some new comments. Please see SUPPORT-5972. |
| Comment by Richard Gange [ 20/Apr/16 ] |
|
When looking into this issue please keep in mind that some browsers may autocorrect markup in the browser. Masking the issue. |
| Comment by Richard Gange [ 07/Jun/16 ] |
|
The Magnolia Release is wrong on this ticket. It should be 5.4.7. |