[MGNLDMS-169] Ant Zipfile is not needed anymore since we switched to Java 5 Created: 06/Aug/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Document Management System (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major
Reporter: Jan Haderka Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLDMS-167 Zipfile upload to DMS broken with NoC... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

ZipFile from ant-1.6.5 have been used in ZipUpload to work around Java 1.4.2 bug http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4244499
Since the bug is fixed in Java 1.5 and we do not support Java 1.4.2 any more there is no longer need to use ant based ZipFile in ZipUpload. Removing use of ant will reduce size of the bundle by 1MB.

-rw-r--r-- 1 had had 1034049 2009-07-24 11:31 ant-1.6.5.jar


 Comments   
Comment by Magnolia International [ 06/Aug/09 ]

We'll need to be careful with this, as there are other tiny differences between the two implementations (entry order comes to mind: see MGNLDMS-129)

Comment by Jan Haderka [ 06/Aug/09 ]

Sure, there is no rush. I just wanted to point out in jira that the original reason for using ant (as described in the code) no longer applies.
Default JDK implementation of Zip file handling has also issue with big files since it keeps entry list in native memory and can run out of memory while handling zip files with many entries (one of the reasons why we use gzip in backup module). This is probably also an issue for ant based implementation (see MGNLDMS-151).

Comment by Philipp Bärfuss [ 30/Aug/10 ]

Or we could alternatively use http://commons.apache.org/compress/

Comment by Magnolia International [ 30/Aug/10 ]

.. and if we fix this, let's check if MGNLDMS-62 (utf8), MGNLDMS-139 and MGNLDMS-151 (memory issues) still apply.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 00:49:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.