[MGNLDMS-185] DMSDownloadServlet logs error messages on client abort Created: 17/May/10 Updated: 04/Nov/15 Resolved: 04/Nov/15 |
|
| Status: | Closed |
| Project: | Document Management System (closed) |
| Component/s: | None |
| Affects Version/s: | 1.4.3 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | Oliver Siegmar | Assignee: | Philipp Bärfuss |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Tomcat 6.0.26 |
||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
The DMSDownloadServlet logs error messages on client abort - 2010-05-15 00:00:07,261 ERROR info.magnolia.module.dms.DMSDownloadServlet - error during download
ClientAbortException: java.net.SocketException: Connection reset
at org.apache.catalina.connector.OutputBuffer.realWriteBytes(OutputBuffer.java:358)
at org.apache.tomcat.util.buf.ByteChunk.flushBuffer(ByteChunk.java:434)
at org.apache.tomcat.util.buf.ByteChunk.append(ByteChunk.java:349)
at org.apache.catalina.connector.OutputBuffer.writeBytes(OutputBuffer.java:381)
at org.apache.catalina.connector.OutputBuffer.write(OutputBuffer.java:370)
at org.apache.catalina.connector.CoyoteOutputStream.write(CoyoteOutputStream.java:89)
at info.magnolia.module.dms.DMSDownloadServlet.sendUnCompressed(DMSDownloadServlet.java:124)
at info.magnolia.module.dms.DMSDownloadServlet.handleResourceRequest(DMSDownloadServlet.java:109)
at info.magnolia.module.dms.DMSDownloadServlet.process(DMSDownloadServlet.java:185)
at info.magnolia.module.dms.DMSDownloadServlet.doGet(DMSDownloadServlet.java:75)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:183)
...
This has once been fixed in I'd suggest to catch the IOException rather then the SocketException in DMSDownloadServlet. |
| Comments |
| Comment by Matt Dertinger [ 25/Oct/11 ] |
|
Hi, I've attached a patch that uses a slightly modified version of the code provided by Danilo at
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
try {
process(request, response);
}
catch (IOException ioe) {
Throwable wrappedException = ExceptionUtils.getCause(ioe);
if (!((wrappedException != null) && (StringUtils.equalsIgnoreCase(ioe.getClass().getName(),
"org.apache.catalina.connector.ClientAbortException")))) {
// log error message ONLY if it's not a client abort.
log.error("IOExeption during download", ioe);
} else {
log.debug("ClientAbortException during download");
}
}
catch (Exception e) {
log.error("error during download", e);
}
}
Let me know if you have any questions. Cheers, |
| Comment by Michael Mühlebach [ 04/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |