[MGNLEE-146] Installer should not allow updates. .. Created: 05/Jun/09  Updated: 23/Jun/14  Resolved: 08/Jun/09

Status: Closed
Project: Magnolia DX Core
Component/s: installer
Affects Version/s: None
Fix Version/s: 4.1, 4.0.2

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
supersedes MGNLEE-144 Installer fails with openwfe-1.7.2.1.... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

This is quite silly, but as a quick-fix, we should make the installer refuse to overwrite an existing Magnolia... because it doesn't overwrite; you end up with tons of duplicate jars (different versions) - and we can't just make it overwrite everything either, since that would trash the repository.



 Comments   
Comment by Magnolia International [ 05/Jun/09 ]

Boris, could you please validate/complete the following (new) message in the installer?

  <str id="NoUpdatesAllowedTargetPanel.noUpdatesAllowed">Das Verzeichnis existiert bereits und ist nicht leer:
{0}
If you need to update an existing Magnolia instance, please refer to the documentation.
This operation is currently not supported by this installer.</str>

Thanks !

(doing this because overwriting an existing installation with the installer currently really doesn't work - if we ever upgrade to a newer IzPack this might be possible to implement)

Comment by Boris Kraft [ 06/Jun/09 ]

I would clearly state that overwriting an existing installation is not allowed. In fact I would have simply moved any existing installation to some backup folder if found, and then stated so.

But here you go:

"We found an existing Magnolia-installation at {$0}. This installer does not support the update of an existing installation. Please (click back and) select a different location."

"Das von Ihnen ausgewählte Installationsverzeichnis {$0} enthält bereits eine frühere Version von Magnolia. Dieses Installationsprogramm kann keine existierenden Installationen überschreiben. Bitte wählen Sie ein anderes Installationsverzeichnis aus."

Comment by Magnolia International [ 08/Jun/09 ]

I would clearly state that overwriting an existing installation is not allowed.

That's what "This operation is currently not supported by this installer." was saying, in my original message.

In fact I would have simply moved any existing installation to some backup folder if found, and then stated so.

The installer currently has no idea what it would be overwriting, it just sees a non-empty directory, which could just as well be any other application or what not. (so your message isn't exactly appropriate - care to change it to reflect this?)

Comment by Boris Kraft [ 08/Jun/09 ]

New messages after discussions:

"You have selected {$0} for your installation. This directory is not empty. This installer does not support the update of an existing installation. Please (click back and) select a different location."

"Das von Ihnen ausgewählte Installationsverzeichnis {$0} ist nicht leer. Dieses Installationsprogramm kann keine existierenden Installationen überschreiben. Bitte wählen Sie ein anderes Installationsverzeichnis aus."

Comment by Magnolia International [ 08/Jun/09 ]

An existing empty directory still asks for confirmation - would require yet another patch to izpack.

Generated at Mon Feb 12 05:27:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.