[MGNLEE-374] EnterpriseLicenseFileExtractor should include method to supply the complete magnolia Edition name Created: 24/Sep/14 Updated: 25/Sep/14 Resolved: 25/Sep/14 |
|
| Status: | Closed |
| Project: | Magnolia DX Core |
| Component/s: | None |
| Affects Version/s: | 5.3.3 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Christopher Zimmermann |
| Resolution: | Outdated | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
In order for the About app to be able to display whether the Edition is "pro" or "standard", LicensefileExtractor should implement a new method getEditionFromLicenseKey which returns the detailed information. (Since the license.xml file includes only more generic 'Enterprise Edition' with no info about whether its standardard or pro.) |
| Comments |
| Comment by Christopher Zimmermann [ 24/Sep/14 ] |
|
Add method EnterpriseLicenseFileExtractor#getEditionFromLicenseKey which returns name of edition including Standard or Professional. |
| Comment by Jan Haderka [ 25/Sep/14 ] |
|
This method doesn't belong in this class. Or at the very least the implementation as it is done doesn't. Javadoc clearly states and file name implies that this file is meant to extract info about Magnolia from the license.xml file created during build to provide information about the build. It has nothing to do with the actual license key that is the only source of information about the edition that user is licensed to use. |
| Comment by Christopher Zimmermann [ 25/Sep/14 ] |
|
It was decided to customize the AboutApp itself with an enterprise edition of some of its classes. So this is not necessary. |