[MGNLEE-403] Create bundled webapp for EE standard Created: 05/Mar/15 Updated: 15/Apr/16 Resolved: 05/Oct/15 |
|
| Status: | Closed |
| Project: | Magnolia DX Core |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.3 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Natascha Desmarais | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | support | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d 2h 35m | ||
| Original Estimate: | 0.25d | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Release notes required: |
Yes
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | Separate bundles from magnolia main project, introduce ce/ee-packs | ||||||||||||
| Sprint: | Kromeriz 13 | ||||||||||||
| Story Points: | 3 | ||||||||||||
| Description |
|
It would be good to create an EE standard license compliant bundle. Right now one has to exclude 7 modules (1 multisite, 6 for personalization) to create a working project from the magnolia-enterprise-webapp. This is fine as long as this was known before the project start, however, it is a bigger maintenance issue if the project is already live/has content and those modules need to be manually uninstalled. enterprise-webapp builds upon "standard-webapp" that builds upon empty-webapp. |
| Comments |
| Comment by Natascha Desmarais [ 05/Mar/15 ] |
|
Current WORKAROUND to do this properly is within the POM of the webapp using exclusions on the pom-dep (not the war-dep).
<dependency>
<groupId>info.magnolia.eebundle</groupId>
<artifactId>magnolia-enterprise-webapp</artifactId>
<type>pom</type>
<exclusions>
<exclusion>
<groupId>info.magnolia.personalization</groupId>
<artifactId>magnolia-personalization-integration</artifactId>
</exclusion>
<exclusion>
<groupId>info.magnolia.personalization</groupId>
<artifactId>magnolia-personalization-personas-app</artifactId>
</exclusion>
<exclusion>
<groupId>info.magnolia.personalization</groupId>
<artifactId>magnolia-personalization-preview-app</artifactId>
</exclusion>
<exclusion>
<groupId>info.magnolia.personalization</groupId>
<artifactId>magnolia-personalization-samples</artifactId>
</exclusion>
<exclusion>
<groupId>info.magnolia.personalization</groupId>
<artifactId>magnolia-personalization-segmentation-app</artifactId>
</exclusion>
<exclusion>
<groupId>info.magnolia.personalization</groupId>
<artifactId>magnolia-personalization-traits</artifactId>
</exclusion>
</exclusions>
</dependency>
To exclude multisite the following exclusion could be added:
<exclusion>
<groupId>info.magnolia.multisite</groupId>
<artifactId>magnolia-module-multisite</artifactId>
</exclusion>
However note that this might not be as trivial, since some other modules depend on its existence to be installed, but don't need multisite to be working. One example is the marketing tags manager. But multisite should usually not cause any issues with a standard licence, one can even create more site definitions, but they simply won't work. I would recommend leaving multisite in as long as we have cases like the marketing tags manager app. |
| Comment by Philip Mundt [ 18/May/15 ] |
|
| Comment by Magnolia International [ 18/May/15 ] |
|
Additionally, I'd like to question why this needs to be in 5.3.x. Can't we do this just in 5.4 ? (introducing artifacts in minor versions is confusing – and probably prevent you from renaming existing ones, which may actually benefit from a rename in this case) |
| Comment by Philip Mundt [ 19/May/15 ] |
|
Moved issue to MGNLEE and adjusted fixVersion to 5.4. |
| Comment by Natascha Desmarais [ 20/May/15 ] |
|
The issue with multisite and marketing tags has been resolved with MGNLTAGS-56 (this sets multisite as optional within the module descriptor) so multisite can and should be out of the standard enterprise webapp as well. I would suggest thorough testing regarding this though, some other modules might create the same issue without us being aware of it. |
| Comment by Milan Divilek [ 05/Oct/15 ] |
|
Personalization module is EE standard from M5.4. So only multisite module shouldn't be in standard webapp. |