[MGNLEE-463] Remove duplicate magnolia.properties to prevent inconsistencies and rather patch at build time Created: 11/Oct/16  Updated: 31/Oct/16  Resolved: 31/Oct/16

Status: Closed
Project: Magnolia DX Core
Component/s: build / bundling
Affects Version/s: 5.4.9
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Mikaël Geljić Assignee: Ilgun Ilgun
Resolution: Won't Fix Votes: 0
Labels: blocked, maven, properties, webapp
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File no-replacement.png     Text File potentialSolution.patch    
Issue Links:
causality
caused by MGNLEE-454 Add widget set pro into the Enterpris... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 67
Story Points: 3

 Description   

As part of MGNLEE-454, default magnolia.properties were duplicated into ee-pro-webapp sources—for the sake of using the MagnoliaProWidgetSet.

This means all changes on the empty-webapp's default config would have to be replicated there. This is not sustainable, living proof being that in a couple months time, it already diverged with respect to 1. default directory for FS resources and 2. still using derby config instead of H2.

This must be done at build time instead.
Default magnolia.properties need to be extracted from the empty-webapp's war artifact, and patched in the maven ways.



 Comments   
Comment by Federico Grilli [ 12/Oct/16 ]

QA: Alas, this did not work as expected. No replacement happened.

Comment by Philip Mundt [ 12/Oct/16 ]

EE UI test webapp didn't have the correct widgetset.

Generated at Mon Feb 12 05:30:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.