[MGNLEE-493] Scheduled license check might throw NPE Created: 19/May/17 Updated: 19/May/17 |
|
| Status: | Open |
| Project: | Magnolia DX Core |
| Component/s: | None |
| Affects Version/s: | 5.5.4 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Philip Mundt | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Description |
|
When starting a vanilla Magnolia instance without entering a license, the scheduled license check might throw a NPE: [INFO] [talledLocalContainer] java.lang.NullPointerException [INFO] [talledLocalContainer] at info.magnolia.enterprise.commands.CheckLicenseCommand.getEditionName(CheckLicenseCommand.java:119) [INFO] [talledLocalContainer] at info.magnolia.enterprise.commands.CheckLicenseCommand.execute(CheckLicenseCommand.java:96) [INFO] [talledLocalContainer] at info.magnolia.commands.MgnlCommand.executeSynchronized(MgnlCommand.java:80) [INFO] [talledLocalContainer] at info.magnolia.commands.MgnlCommand.execute(MgnlCommand.java:69) [INFO] [talledLocalContainer] at info.magnolia.module.scheduler.CommandJob.execute(CommandJob.java:110) [INFO] [talledLocalContainer] at org.quartz.core.JobRunShell.run(JobRunShell.java:202) [INFO] [talledLocalContainer] at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) The code should account for situations where no license was entered yet – be more failsafe. |