[MGNLEE-838] dx-core-test-webapps should not throw ClassNotFoundEx (master) Created: 08/Jan/24  Updated: 18/Jan/24  Resolved: 18/Jan/24

Status: Closed
Project: Magnolia DX Core
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0

Type: Task Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Resolved Votes: 0
Labels: TAE
Remaining Estimate: Not Specified
Time Spent: 5h
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLWORKFLOW-470 Workflow bootstraps reference old cla... Open
is related to MGNLPN-774 personalization-samples .. segments.E... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: TAE-build-or-infra-tasks
Work Started:

 Description   

dx-core-test-webapps on 6.3 / om master-branch - throw many ClassNotFoundException.

We need to clean-up the artifact to avoid these ClassNotFoundException.

Some of the CassNotFoundEx

Template-Samples
ClassNotFoundException: info.magnolia.module.samples.templates.SampleTemplate

Tasks, Publishing
ClassNotFoundException: info.magnolia.module.workflow.jbpm.humantask.view.PublicationTaskPresenter
ClassNotFoundException: info.magnolia.module.workflow.action.WorkItemLocalizedDiffActionDefinition
and some more

p13n
ClassNotFoundException: info.magnolia.personalization.geoip.CountryVoter



 Comments   
Comment by Christoph Meier [ 09/Jan/24 ]

Finding for p13n

ClassNotFoundException: info.magnolia.personalization.geoip.CountryVoter
Detail on gist

The class info.magnolia.personalization.geoip.CountryVoter is part of the magnolia-personalization-compatibility artifact, which is not part of the webapp anymore on 6.3.

CountryVoter allegedly gets referenced from personalization-segmentation-app, at least this is what I understand from sratup-log (see gist above)

The class info.magnolia.personalization.geoip.CountryVoter is referenced in many bootsrap-file in dx-core/integration-tests/tests/src/test/resources ... but these files are "only" bootstrapped before the execution of some tests.

The one bootstrap, which goes to the webapp on startup, it is coming from p13n-samples module, it is this:
personalization/magnolia-personalization-samples/src/main/resources/mgnl-bootstrap-samples/personalization-samples/personalization-segmentation-app/segments.Economic-regions.xml

Comment by Christoph Meier [ 17/Jan/24 ]

The following resources have reference to info.magnolia.personalization.geoip.CountryVoter

  • segments.test-regions.yaml
  • segments.test-seg.yaml
  • website.test-contact.yaml
  • website.test-publish-variants.yaml
  • website.test-root.component-variants-ch.yaml

These resources are bootstrapped specifially for specific tests - but will lead to problems in most cases.

I added similar comment to MGNLPN-669

Comment by Christoph Meier [ 17/Jan/24 ]

Was able to get rid of
ClassNotFoundException: info.magnolia.module.samples.templates.SampleTemplate

Deleted samples/templates/pages/ftl/main.yaml referencing not existing info.magnolia.module.samples.templates.SampleTemplate.

For this we have  PR linked to this ticket

Comment by Christoph Meier [ 17/Jan/24 ]

To get rid of
ClassNotFoundExceptions:
 - info.magnolia.module.workflow.jbpm.humantask.view.PublicationTaskPresenter
 - info.magnolia.module.workflow.action.WorkItemLocalizedDiffActionDefinition

We need a fix in the workflow-modules.
Ticket created. See MGNLWORKFLOW-470

Generated at Mon Feb 12 05:33:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.