[MGNLEESOLR-40] Hardcoded labels and descriptions in template and dialog definitions Created: 30/Jan/15  Updated: 01/Feb/16  Resolved: 25/Jan/16

Status: Closed
Project: Solr Search Provider
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.1

Type: Bug Priority: Neutral
Reporter: Milan Divilek Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d 22m
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-6488 Improve key generator for templates Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 28
Story Points: 2

 Description   

I18 should be used for label and description fields.



 Comments   
Comment by Jan Haderka [ 01/Dec/15 ]

Produce a script to automate this task rather than doing it manually.

Comment by Roman Kovařík [ 03/Dec/15 ]

To be done as DEV-59. Switching this ticket back to resolved.

Comment by Roman Kovařík [ 03/Dec/15 ]

Please set versions.

Comment by Roman Kovařík [ 07/Dec/15 ]

Redundant key 'save changes' in node /modules/solr-search-provider/dialogs/pages/solrSearchResult/actions/commit/label
Redundant key 'cancel' in node /modules/solr-search-provider/dialogs/pages/solrSearchResult/actions/cancel/label
Hardcoded key 'STK - Solr Search Results' in node /modules/solr-search-provider/templates/pages/solrSearchResult/title
(templates.pages.solrSearchResult.title=STK - Solr Search Results)

Missing label: solr-search-provider:pages/mteSolrSearchResult

The keys for templates and dialogs has to be set in configuration.

Comment by Roman Kovařík [ 08/Dec/15 ]

Reopened: At least templates must have key in the old i18n location and i18nBasename set.

Comment by Roman Kovařík [ 11/Dec/15 ]

QA:

  1. bunch of the components have the same key for description after update: "solr-search-provider.components.facetBox.description"
  2. Setting of /modules/solr-search-provider/templates/pages/solrSearchResult@i18nBasename breaks the i18n keys for whole page (e.g. AREAS.TEMPLATES.MAIN.CONTENT.TITLE. We should keep the hardcoded title for the page template.
  3. Missing keys for range faced selector dialog (e.g. solr-search-provider.rangeFacetSelector.tabMain.label and all others)
  4. Similar search result dialog: max results per page -> Max results per page
  5. Considering this is already the second failed integration, we should add test to the module version handler.
Comment by Milan Divilek [ 17/Dec/15 ]

Reopen: There is still set /modules/solr-search-provider/templates/pages/solrSearchResult@i18nBasename which breaks i18n for whole page...

Generated at Mon Feb 12 10:59:30 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.