Refactoring of search providers, model classes and freemarker templates (MGNLEESOLR-22)

[MGNLEESOLR-59] Schema fields and additional filters are resolved also when not needed Created: 09/Apr/15  Updated: 24/Apr/15  Resolved: 14/Apr/15

Status: Closed
Project: Solr Search Provider
Component/s: None
Affects Version/s: None
Fix Version/s: 2.2

Type: Sub-task Priority: Neutral
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Date of First Response:

 Description   

info.magnolia.search.solrsearchprovider.logic.providers.FacetedSolrSearchProvider provides simple "caching" of search results. When user triggers same query twice or more in row, then search is done only for the first search. For following search the results from first search are used, but solr schema fields and additional filters are resolved unnecessary also for the following search.



 Comments   
Comment by Jan Haderka [ 13/Apr/15 ]
   public Collection<String> getSchemaFields() {
        ...
        return null;

Since you are returning null in public method, you should describe in javadoc the conditions under which that might happen ... or change it to return empty collection instead.

Comment by Milan Divilek [ 14/Apr/15 ]

This was refactored in MGNLEESOLR-53, method doesn't return null anymore. Instead of it exceptions are thrown. Added "@throws" javadoc.

Generated at Mon Feb 12 10:59:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.