[MGNLEESOLR-67] Support Solr 5 Created: 30/Jun/15  Updated: 15/Apr/16  Resolved: 12/Oct/15

Status: Closed
Project: Solr Search Provider
Component/s: None
Affects Version/s: 3.0
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Edgar Vonk Assignee: Evzen Fochr
Resolution: Fixed Votes: 1
Labels: support
Remaining Estimate: 0d
Time Spent: 2.5d
Original Estimate: Not Specified

Issue Links:
causality
dependency
depends upon MGNLEESOLR-85 Integer.MAX_VALUE is too big for maxR... Closed
depends upon MGNLEESOLR-83 Remove hardcoded DEFAULT_SEARCH_FIELD Closed
depends upon MGNLEESOLR-84 Create new example solrconfig and man... Closed
duplicate
is duplicated by MGNLEESOLR-68 Support Solr 5 Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Sprint: Kromeriz 14
Story Points: 2

 Description   

Test and certify Magnolia Solr integration with Solr 5.

Schemaless mode (https://cwiki.apache.org/confluence/display/solr/Schemaless+Mode) seems to work without any problems.
Indexing itself seems to work without problems.

Additional tests need to be described here and performed.



 Comments   
Comment by Milan Divilek [ 09/Oct/15 ]

Reopen:
Please rename parameter name and method name from *server to *client

-    private void configureSolrServer(HttpSolrServer solrServer, SolrServerConfig solrServerConfig) {
+    private void configureSolrServer(HttpSolrClient solrServer, SolrServerConfig solrServerConfig) {

There's probably no easy way how to deprecate info.magnolia.search.solr searchprovider.config.SolrServerConfig class to be back compatible, but could you change "server" to "client" in log messages and javadoc on places where it make sense? For example here : info.magnolia.search.solrsearchprovider.MagnoliaSolrBridgeImpl#configureSolrServer -> log.info("Initializing Solr server with the following values {}", solrServerConfig.toString()); or in javadoc for info.magnolia.search.solrsearchprovider.MagnoliaSolrBridge#getSolrClient method.

And update module version to version 5.0

Comment by Milan Divilek [ 12/Oct/15 ]

Reopen: info.magnolia.search.solrsearchprovider.logic.model.FacetedSearchResultModel#execute still use deprecated HttpSolrServer.RemoteSolrException

Generated at Mon Feb 12 10:59:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.