[MGNLETK-111] By usage of smartphone variation, all links are created as external links, in sites with no domain configured Created: 06/Nov/13 Updated: 22/Oct/14 Resolved: 07/Oct/14 |
|
| Status: | Closed |
| Project: | Extended Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | 2.0.21 |
| Fix Version/s: | 2.0.22 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Frank Sommer | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
If you are using a variation on site definition like the smartphone variation, all links on the smartphone view are rendered as external (complete with host) links. The reason for this bug is, that the SiteMergeFilter creates site proxies, if a variation is used. The equals comparison in the CompoundLinkTransformer fails on usage with site proxies. And so the link transformer creates external link for links in same site, too. To reproduce this issue create a new home page and view the source code of the smartphone preview iframe. |
| Comments |
| Comment by Tobias Mattsson [ 04/Dec/13 ] |
|
Moved to ETK because the bug appears to lie in CompoundLinkTransformer. The original ticket specified affects version(s): 4.5.10, 5.1.1 |
| Comment by Gernot Fussan [ 25/Jul/14 ] |
|
Hello, I'd like to add that created links furthermore contain the site definition ("/default/"), which is even more less useful, especially regarding SEO. Kind Regards |
| Comment by Federico Grilli [ 01/Sep/14 ] |
|
Waiting for customer feedback on proposed solution. See also |
| Comment by Christopher Zimmermann [ 03/Sep/14 ] |
|
Can be closed as non-issue once properly documented: The site name is included only when domain is not configured properly. |
| Comment by Antti Hietala [ 04/Sep/14 ] |
|
Documented a best practice about creating a specific site definition. |
| Comment by Christopher Zimmermann [ 11/Sep/14 ] |
|
In CompoundLinkTransformer#isTargetExternal compare the names of sites for equivalence instead of the site objects themselves. |
| Comment by Philip Mundt [ 29/Sep/14 ] |
|
We should add the same tests as in |