[MGNLETK-126] Multisite behavior: Site definition detection in ETKSiteManager does not cover all "corner" cases Created: 18/Mar/14 Updated: 04/Jul/14 Resolved: 03/Jul/14 |
|
| Status: | Closed |
| Project: | Extended Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | 2.0.17 |
| Fix Version/s: | 2.0.21 |
| Type: | Bug | Priority: | Major |
| Reporter: | Christian Ringele | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Release notes required: |
Yes
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
The same behavior also counts for the multi site module of Magnolia 5. Situation (from SUPPORT-3270):
Use case: The problem: Analysis: 2. As the system can not access at this state JCR to determine the site definitions it can only operate on on the site definition configurations them selves. Therefore the system detect a site definition which seems to serve this site (b site is assumed) and can not check if a actual sub page exists. Proof & workaround: Drawback of workaround: Wrong behavior: 2. Not the site definition's name should be used for the link creation (not resulting in "/bbb/d" paths) but its inner value of the mapped handle. Reproduce & test: |
| Comments |
| Comment by Tobias Hitzfeld [ 21/Mar/14 ] |
|
Hallo Just a few additional points from customer side (sorry for my lack of technical know how and my bad english in advance; just missing german documentation and support). business needs:
I think it will be essential at crossSite configurations that during all handling (logging, filter chain) the domain mus be added and recognized separately from the path. Even top level path (in our case the sitename) isn't included in these logfiles but paths are logged. Regards, |
| Comment by Jaroslav Simak [ 29/May/14 ] |
| Comment by Philip Mundt [ 02/Jul/14 ] |
|
Rules should be made configurable, so any "special case" can be individually solved. |
| Comment by Philip Mundt [ 02/Jul/14 ] |
|
| Comment by Philip Mundt [ 02/Jul/14 ] |
|
Attaching rules configuration (config.modules.extended-templating-kit.config.rules.xml) that solves the above case. This config is not by default added to the modules configuration! |
| Comment by Roman Kovařík [ 02/Jul/14 ] |
|
| Comment by Philip Mundt [ 03/Jul/14 ] |
|
| Comment by Roman Kovařík [ 03/Jul/14 ] |
|
To test:
|
| Comment by Roman Kovařík [ 03/Jul/14 ] |
|
Could you remove info.magnolia.module.extendedtemplatingkit.setup.ETKModuleVersionHandlerTest.tearDown() when integrating? (it's done in info.magnolia.test.MgnlTestCase.tearDown() already). |