[MGNLETK-23] Selectors not considered in mapping i18nURI to content Created: 20/Apr/10  Updated: 03/Jul/14  Resolved: 22/Jul/10

Status: Closed
Project: Extended Templating Kit (closed)
Component/s: None
Affects Version/s: 1.2.3
Fix Version/s: 1.3.1

Type: Bug Priority: Major
Reporter: Matteo Pelucco Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: etk, i18n, selector, selectors
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File ETKI18nContentSupport.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

With i18n enabled (it is also present in default i18n support), an URL with selectors inside, still valid in Magnolia 4.1 and 4.2, all links of a page accessed with a selector in URL are "null".

e.g: URL like "/magnoliaAuthor/test.html" are OK
e.g: URL like "/magnoliaAuthor/test.123.html" are KO

You can try even on a demo-project website.

Object involved:
ETK 1.1.2
ETKI18nContentSupport.java

Patch provided.



 Comments   
Comment by Jan Haderka [ 21/Apr/10 ]

Hey Matteo,
do you maintain your own copy of the code in svn? there's no "ETKI18nContentSupport.java (revision 33830)" in our svn as far as I can tell (the latest revision of the file in question is 32674 see http://svn.magnolia-cms.com/view/enterprise/magnolia-module-extended-templating-kit/trunk/src/main/java/info/magnolia/module/extendedtemplatingkit/i18n/ETKI18nContentSupport.java?annotate=32674

And also the patch hunk doesn't match that code. The method signature is different and removed code doesn't exist.
... hmm I see now. You generated that patch against ETK 1.1 instead of against trunk ... now I also understand your note in the description. Fair enough.

Comment by Jan Haderka [ 21/Apr/10 ]

Actually the killer of selectors in 4.3 was MultiSiteFilter and this issue was fixed in trunk by changes for MGNLETK-21 and MGNLETK-20

Comment by Jan Haderka [ 21/Apr/10 ]

Applied modified patch to 1.2 branch ... there were other methods where the same workaround had to be applied to make it all work properly.

Comment by Jan Haderka [ 21/Apr/10 ]

Remaining part in current trunk is the authoring support - currently the urls generated by the language switch remove selectors.

Comment by Matteo Pelucco [ 21/Apr/10 ]

Hi Jan, just see your comment.
To enforce, yes, I worked on a tag (/tags/magnolia-module-extended-templating-kit-1.2.3) because I saw that in 4.3.1 ETKi18nContentSupport has completely changed.
I also notice that this code should be fixed somewhere else.. but I am not so confident on whole Magnolia code to say where, I think you could do it better

Matteo

Generated at Mon Feb 12 01:47:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.