[MGNLETK-35] imaging: produce images of the same type as the original Created: 30/Aug/10  Updated: 13/Dec/11  Resolved: 01/Oct/10

Status: Closed
Project: Extended Templating Kit (closed)
Component/s: None
Affects Version/s: 1.3.2
Fix Version/s: 1.3.5

Type: Improvement Priority: Critical
Reporter: Philipp Bärfuss Assignee: Ondrej Chytil
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLIMG-71 CLONE -imaging: produce images of the... Closed
causality
is causing MGNLETK-45 improve the dynamic image type genera... Closed
relation
is related to MGNLETK-36 STK/ETK integration and transparent i... Closed
is related to MGNLIMG-89 BMP file types are not being displaye... Closed
is related to MGNLIMG-76 allow the ImageGenerator produce an O... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The generic image generator used in STK always produces jpgs (hard coded). This should be set dynamically to the type of the source.



 Comments   
Comment by Philipp Bärfuss [ 30/Aug/10 ]

This kind of solves MGNLIMG-60

Comment by Raphael Joss [ 03/Sep/10 ]

Hi Philipp

Do you have any updates?
Are you convinced that you can provide a fix on time?
I'm sorry for the hurry but otherwise we have to find a workaround with the pictures themselves.
We expected the fix by the end of this week.

Comment by Philipp Bärfuss [ 06/Sep/10 ]

The two places where the code has to be adapted: http://pastebin.com/88196W3v

So yes we are able to fix it, not sure what 'on time' means in that regard. If this is related to a support ticket, it would be helpful to link it.

Comment by Raphael Joss [ 06/Sep/10 ]

In SUPPORT-705 I got the information, that this ticket is related to our problem.

Comment by Boris Kraft [ 06/Sep/10 ]

I disagree that output should always be of the same type than input. On the contrary, I think that generally output should be of a specified type no matter what input you have. The output format however should be configurable, and if somebody thinks he needs to have an option "same as input", so be it.

Comment by Philipp Bärfuss [ 07/Sep/10 ]

As for now the output format is set system/site wide and even worse, it is kind of hard coded to jpg. This is especially a problem if you use transparent png/gifs. The synchronization of the input/output is just the better default behavior but surely not where we aim to.

But true this should be configurable.

Comment by Philipp Bärfuss [ 07/Sep/10 ]

This kind of solves MGNLIMG-60

Unfortunately not true, this fix will only guarantee that jpg and png can be handled as expected. It will not solve MGNLIMG-60.

Comment by Jan Haderka [ 30/Sep/10 ]

OutputFormat has now different constructor. The original constructor needs to be kept there (possibly deprecated), defaulting the "dynamicOutput" value to false to keep the original behavior and depending code intact.

Comment by Jan Haderka [ 30/Sep/10 ]

Update version in the VersionHandler to match the version of the module to be released.
Move update task for imaging generators to the imaging module where it really belongs.

Generated at Mon Feb 12 01:47:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.