[MGNLETK-36] STK/ETK integration and transparent images Created: 09/Dec/09 Updated: 14/Oct/10 Resolved: 09/Sep/10 |
|
| Status: | Closed |
| Project: | Extended Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.5 |
| Type: | Bug | Priority: | Major |
| Reporter: | Zdenek Skodik | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Description |
|
When a transparent png is resized through the imaging module (using getAssetLink), the image gets messed up. See related support issue. |
| Comments |
| Comment by Zdenek Skodik [ 17/Dec/09 ] |
|
Requested config attached. We can't keep the image in source repository |
| Comment by Magnolia International [ 22/Jan/10 ] |
|
Finally identified this one. In info.magnolia.module.extendedtemplatingkit.imaging.generation.SimpleResizeVariation, we generate an ImageOperationChain. The load operation (FromNodeData) isn't currently configurable in this context, but in this case, setting its backgroundColor property to white should "hide" the issue. Ideally though, what we want is keep this image transparent. I believe it's saved as a jpeg, thus loosing transparency. Emma, would you mind trying setting modules/imaging/config/generators/stk/outputFormat/formatName to png instead of jpg. I think that should solve this specific case. Unfortunately, we can't really say that's a fix for the general case, as converting to png won't be ideal for photos, for example. |
| Comment by Magnolia International [ 05/May/10 ] |
|
Just found out that setting the output format like specified above isn't enough. The image link is generated at info.magnolia.module.extendedtemplatingkit.imaging.generation.ImageOperationProvidingVariation#createLink, and that's hardcoded to use the .jpg extension. |
| Comment by Jan Haderka [ 09/Sep/10 ] |
|
The default integration preferred speed over quality. Changed code uses resizer providing higher quality output. |