[MGNLETK-57] ETKSiteManager in use with domain mappings: should return currentSite if no explicit repository mapping was detected. Created: 26/May/11 Updated: 23/Aug/11 Resolved: 17/Aug/11 |
|
| Status: | Closed |
| Project: | Extended Templating Kit (closed) |
| Component/s: | multisite |
| Affects Version/s: | 1.4.2 |
| Fix Version/s: | 1.4.3 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Christian Ringele | Assignee: | Philipp Bärfuss |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Patch included: |
Yes
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Description |
|
Situation: when looking at the rendered URL, it created an external link based on the defaultBaseURL, see print screen. Cause: Correction: |
| Comments |
| Comment by Christian Ringele [ 26/May/11 ] |
|
Was created by solving ETK-49 |
| Comment by Christian Ringele [ 26/May/11 ] |
|
Added better draft patch, old patch was not very smart. |
| Comment by Jan Haderka [ 26/May/11 ] |
|
The way i read this patch it will solve the problem for global resources such as dms content, but at a same time it breaks all the global website content which doesn't belong to any site (such as custom 404 pages, etc.) since with the patch Magnolia will try to read it from the current site and either fetch wrong content or end up with 404. |
| Comment by Christian Ringele [ 26/May/11 ] |
|
That is right, don't use this patch, was just a quick draft. |
| Comment by Philipp Bärfuss [ 27/May/11 ] |
|
There is actually a working workaround:
The mechanism is then accepting the current site as wished. |
| Comment by Philipp Bärfuss [ 27/May/11 ] |
|
A better fix might not only iterate on the direct mappings but also on the indirect ones (the mappings in the central uri mapping). If done so we don't have to change the algorithm. |
| Comment by Philipp Bärfuss [ 29/Jun/11 ] |
|
Scheduling this issue for the next bug fix release. We know how to fix it. |
| Comment by Philipp Bärfuss [ 23/Aug/11 ] |
|
Will finally be solved by a new algorithm ( |