[MGNLETK-59] site mapping: don't ignore the uri prefix when trying to match the path Created: 30/Jun/11  Updated: 23/Aug/11  Resolved: 23/Aug/11

Status: Closed
Project: Extended Templating Kit (closed)
Component/s: multisite
Affects Version/s: 1.4.2
Fix Version/s: 1.4.3

Type: Bug Priority: Critical
Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File ETKSiteManager.java     Text File MultiSiteFilter.java     Text File magnolia-module-extended-templating-kit.patch     Text File tests.txt    
Issue Links:
relation
is related to MGNLETK-57 ETKSiteManager in use with domain map... Closed
supersession
is superseded by MGNLETK-62 multisite detection: implement a rule... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:
Visible to:
Raphael Joss

 Description   

Otherwise all mappings which have an empty path (or /) will map.



 Comments   
Comment by Philipp Bärfuss [ 30/Jun/11 ]

Attached a drafted fix which we implemented while debugging.

Comment by Stefan Baur [ 30/Jun/11 ]

thank you very much for the patch. But as we are using git, meight it be possible to give us the two .class (or even .java??) files?
Like that I just can put them into the WEB-INF/classes directory to override the provided classes from the magnolia jars.

Thanks for the very appreciated help!

Comment by Stefan Baur [ 01/Jul/11 ]

hi again.

i now have

1) checked out etk
2) changed to revision 46698
3) tried to apply the patch.

I get the error message: "(...) seems to be outdated (...)"

can you give me the java or class file instead?

Comment by Stefan Baur [ 01/Jul/11 ]

I have to increase the importance here (I hate that...) but this solution should get into the baloise release today to meet the go live deadline of the baloise website.

Comment by Christian Ringele [ 01/Jul/11 ]

Patched java classes for SBauer

Comment by Christian Ringele [ 01/Jul/11 ]

For Stefan Bauer
Against etk 1.4.2
removed unused imports so checkstyle won't fail.

Comment by Stefan Baur [ 01/Jul/11 ]

very nice, the first test seems to work nicely!

Comment by Stefan Baur [ 01/Jul/11 ]

don't I need to add a dms mapping to the site def at all?

Comment by Philipp Bärfuss [ 17/Aug/11 ]

the failing tests for the ETKSiteManager. the tests for the MultisiteFilter (url cleanup) is still missing.

Comment by Philipp Bärfuss [ 17/Aug/11 ]

Now that MGNLETK-57 is fixed this is not urgent anymore. Just don't add unnecessary empty mappings.

Comment by Philipp Bärfuss [ 23/Aug/11 ]

Will finally be solved by a new algorithm (MGNLETK-62).

Comment by Philipp Bärfuss [ 23/Aug/11 ]

fixed by implementing MGNLETK-62

Comment by Jan Haderka [ 23/Aug/11 ]

Pls next time mention all the tickets fixed by the commit in the commit message.

Generated at Mon Feb 12 01:48:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.