[MGNLETK-87] Update pom dependency & version handler in order to use the new migration process Created: 19/Oct/12  Updated: 15/Jul/13  Resolved: 06/Dec/12

Status: Closed
Project: Extended Templating Kit (closed)
Component/s: None
Affects Version/s: 2.0.6
Fix Version/s: 2.0.7

Type: Task Priority: Neutral
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLETK-92 port update pom dependency & version ... Closed
is related to MGNLMIGRATION-117 Migrated Modules configuration: ETK Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Add dependency on the POM to the migration module.
Create a new version handling task in order to migrate configuration.
Add an Extra Migration sub Task (Post Migration specific task).



 Comments   
Comment by Jan Haderka [ 26/Nov/12 ]

Like with all other migration/update task issues. Since you are adding task in version 2.0.7 to the update to version 2.0, you need to explain either in comment in the code or in the issue why this task can't be executed in update to 2.0.7. What happens if someone updates from 1.4 to 2.0 and then to 2.0.7? In this case they would never execute the task. Is this ok? How/why?

Comment by Eric Hechinger [ 30/Nov/12 ]

Add a migration task in the version handler in order to migrate the ETK module from 4.4.6 to 4.5.7 and higher.
Magnolia 4.4.6 shipped ETK 1.4.4
Magnolia 4.5.0 shipped ETK 2.0

If a Magnolia instance is updated from 4.4.6 to 4.5.7, the version handler (DeltaBuilder.update("2.0", "")) will take care of the migration of the module.
If a Magnolia instance was already updated let say from 4.4.6 to 4.5.6 (Version 2.0.6 of the ETK module) and we want now to update to Magnolia 4.5.7, in this case, the version handler's will not run the migration.
Migration already took place during update from 4.4.6 to 4.5.6. and should not run again.
This is exactly what we expected.

Comment by Jan Haderka [ 02/Dec/12 ]

Some changes appear to be done only on master, some only on 2.0.x branch. Can you double check and make sure all is applied where appropriate?

Comment by Eric Hechinger [ 06/Dec/12 ]

I cross checked and compare following classes from the 2.0.x branch and master:

  • ETKModuleVersionHandler in synch.
  • extended-templating-kit.xml in synch.
  • pom.xml in synch. regarding the dependency with the migration module.
Generated at Mon Feb 12 01:48:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.