[MGNLFE-124] Move the personalization service from libraries to demos Created: 27/Sep/21 Updated: 18/Oct/21 Resolved: 11/Oct/21 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.1.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Bartosz Staryga | Assignee: | Canh Nguyen |
| Resolution: | Done | Votes: | 0 |
| Labels: | VN-Implementation | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 1d 1h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Headless p13n | ||||||||
| Sprint: | HL & LD 38, HL & LD 39 | ||||||||
| Story Points: | 1 | ||||||||
| Description |
|
Currently in client side we need to add some parameters to call fetching pages: It would be bit easier if could on client side to following: If preview iframe URL is: /travel/?mgnlPreview=false&mgnlChannel=desktop If preview iframe URL is: /travel/?previewPersona=%2FSara-Byrne&mgnlPreviewAsVisitor=true Why it's good?
Looks like for personalization you'd have to start adding `variants=all` to iframe preview URL. |
| Comments |
| Comment by Christopher Zimmermann [ 27/Sep/21 ] |
|
Do I get it right - that you are suggesting to not add the PersonalizationService to the libraries - and that the impact would be to change this demonstration project to always append full querystring in requests to the delivery endpoint? |
| Comment by Bartosz Staryga [ 27/Sep/21 ] |
|
Should it be "add ALL query search parameters when fetching delivery endpoint"? Regarding `variants=all` Regarding adding PersonalizationService It's very nice for future if we e.g. decide to modify how things work in p13n, name of params e.g. or we add new feature `topherView` which will make rest endpoint return everything translated in klingon. |
| Comment by Christopher Zimmermann [ 27/Sep/21 ] |
|
Discussed with canh.nguyen and headless team and we agreed to remove public Personalization methods from library code. (And add them to the demo project as an example of implemenation.) |