[MGNLFE-135] Only render page annotation when the template annotations is passed Created: 15/Oct/21  Updated: 27/Oct/21  Resolved: 25/Oct/21

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1.2

Type: Task Priority: Neutral
Reporter: Robert Šiška Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLFE-119 templateAnnotations/templateDefinitio... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: External SPA
Sprint: HL & LD 39, HL & LD 40
Story Points: 0

 Description   

In effort to keep the action bar working in external SPA, we rendered the root HTML annotation for the page even when the template annotations weren't passed to EditableArea.

 

However, broken action bar isn't a concert for customers and the page annotation being always rendered caused some confusion.



 Comments   
Comment by Christopher Zimmermann [ 18/Oct/21 ]

Regarding "However, broken action bar isn't a concert for customers " - That does not sound right to me... in what context does the customer not concerned with broken action bar? Or when will they see a broken action bar with this change?

Comment by Christopher Zimmermann [ 18/Oct/21 ]

Would someone ever use the page editor without the TemlateAnnotations or TemplateDefintiions?

Comment by Robert Šiška [ 25/Oct/21 ]

To clarify: nobody excepts the action bar to work if you don't pass either annotations or definitions. In that case, "broken" actionbar is expected.

Generated at Mon Feb 12 05:44:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.