[MGNLFE-149] 6.2.13, Angular 12, 1.1.2 angular-editor no green bars on child pages Created: 17/Nov/21  Updated: 17/Dec/21  Resolved: 17/Dec/21

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.0

Type: Bug Priority: Critical
Reporter: Bartosz Staryga Assignee: Canh Nguyen
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 0.75d
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2021-11-17 at 09.23.41.png     PNG File Screenshot 2021-11-17 at 09.24.11.png     PNG File image-2021-11-22-14-53-15-131.png     Zip Archive light-modules.zip     Zip Archive magnolia-spa.zip     GIF File render-green-bars-with-angular-editor-1.1.3-SNAPSHOT.gif    
Issue Links:
Relates
relates to MGNLFE-148 Can not install 1.1.2 angular-editor ... Closed
relates to MGNLFE-152 MagnoliaEditorBar doesnt show Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Steps to reproduce

  1.  Copy LMs from attached file
  2.  Build the Angular app from attached file
    npm i // when running you might need to pass --force due to MGNLFE-148
    ng build --deploy-url /magnoliaAuthor/.resources/spa/webresources/
  3. Copy resulted files to light-modules/spa/webresources
  4. Create page `spa-home` with SPA Home template
  5. Create sub page with SPA Home or SPA Contact

Expected results

Green bars on all pages

Actual results

Green bars only on home page

Workaround

Use angular-editor 1.0.6



 Comments   
Comment by Bartosz Staryga [ 17/Nov/21 ]

I might be doing here sth wrong code-wise, but can't see it

Comment by Christopher Zimmermann [ 17/Nov/21 ]

Work around can be to use angular-editor 1.0.6, right bstaryga ?

Comment by Bartosz Staryga [ 17/Nov/21 ]

czimmermann yes, you are correct. I forgot to add that.
Using 1.0.6 brings back the green bars to all pages.

Comment by Canh Nguyen [ 22/Nov/21 ]

I've tried to use the newest angular-editor with the fix from MGNLFE-148, and it worked fine.

If you want to try MGNLFE-148's PR with npm link, please add following config to tsconfig.json:

"paths": {
    "@angular/*": ["node_modules/@angular/*"]
} 

Comment by Robert Šiška [ 26/Nov/21 ]

Could you please try again with 1.2.0-beta version with Canh's suggestion from above? We hope it will resolve the issue.

Comment by Christopher Zimmermann [ 29/Nov/21 ]

I've tested with 1.2.0-beta (without taking the step mentioned in Canh's post.) with node 16/npm 8, and the pages are working as expected.

They are also working when I switch to using external-spa.

Comment by Bartosz Staryga [ 29/Nov/21 ]

Confirmed, works well with 1.2.0-beta

Comment by Christopher Zimmermann [ 17/Dec/21 ]

Resolved with 1.2.0

Generated at Mon Feb 12 05:44:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.