[MGNLFE-151] peerDependencies Angular 11+ Created: 20/Nov/21  Updated: 23/Nov/21  Resolved: 23/Nov/21

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: Angular Renderer
Affects Version/s: 1.1.2
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Marcus Hilbe Assignee: Canh Nguyen
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
is duplicated by MGNLFE-148 Can not install 1.1.2 angular-editor ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When using npm install with npm 7+ you got an error. Works with npm 6, since it treats is not as errors, just as warnings. so only Angular 10 will work.

npm ERR! Found: @angular/common@13.0.2
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~13.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^10.2.4" from @magnolia/angular-editor@1.1.2
npm ERR! node_modules/@magnolia/angular-editor
npm ERR!   @magnolia/angular-editor@"1.1.2" from the root project

https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/browse/packages/angular-editor/projects/angular-editor/package.json

  "peerDependencies": {
    "@angular/common": "^10.2.4",
    "@angular/core": "^10.2.4"
  }
 

needs to be changed to ">=10.2.4".

  "peerDependencies": {
    "@angular/common": ">=10.2.4",
    "@angular/core": ">=10.2.4"
  }
 

 



 Comments   
Comment by Canh Nguyen [ 23/Nov/21 ]

This ticket is duplicated by MGNLFE-148.

Generated at Mon Feb 12 05:44:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.