[MGNLFE-158] Let React handles adding/removing template annotations Created: 24/Dec/21 Updated: 05/Apr/22 Resolved: 21/Jan/22 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.2.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Canh Nguyen | Assignee: | Canh Nguyen |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 2d 3h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Release notes required: |
Yes
|
||||
| Documentation update required: |
Yes
|
||||
| Date of First Response: | |||||
| Epic Link: | SPA Editor | ||||
| Sprint: | DevX 1, DevX 2 | ||||
| Story Points: | 3 | ||||
| Team: | |||||
| Description |
|
The react-editor lib inserts/removes extra <div/>, that react is not aware of changes on DOM structure. The new implementation of the react-editor lib will integrate deeply with react lifecycle so it might solve some issues:
|
| Comments |
| Comment by Christopher Zimmermann [ 11/Jan/22 ] |
|
canh.nguyen could you add a short description of what the change in the PR does and how it addresses the problem in the support ticket? (I think it might solve another customers issue too.) |