[MGNLFE-207] version param does not work Created: 02/Jun/22  Updated: 20/Jul/22  Resolved: 20/Jul/22

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Phong Le Quoc Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLFE-232 Simplify usage of frontend-helpers wi... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: SPA Editor Backlog
Story Points: 1
Team: DeveloperX

 Description   

"Preview in tab" always shows the latest version of the page.

Steps:

  • Choose a page that has some versions
  • Click "Show versions" and choose the earliest one
  • The earliest version is shown
  • Click "Preview in tab"

Expected: the earliest version is shown

Actual: the latest version is shown

 

Note: This happens on minimal-headless-spa-demos also https://git.magnolia-cms.com/projects/DEMOS/repos/minimal-headless-spa-demos/pull-requests/22/overview?commentId=96624

 

How to fix:

Use "search" as a parameter instead of "href" when calling the getVersion method.

For angular-sample: fixing in root.component.ts
For react-sample: fixing in App.js
For vue-sample: fixing in PageLoader.vue



 Comments   
Comment by Christopher Zimmermann [ 02/Jun/22 ]

Is the problem in the FrontendHelpers libraries - or do the demonstration projects need to be adapted? (Would be nice if the FE helpers or the Page Editor handles it so that project implementors do not have to worry about it.

Comment by Christopher Zimmermann [ 04/Jul/22 ]

This may be improved by using new getMagnoliaContext approach.

Comment by Phong Le Quoc [ 20/Jul/22 ]

MGNLFE-232 has resolved this issue also.

Generated at Mon Feb 12 05:45:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.