[MGNLFE-272] vue-editor 1.2.3-beta don't render green bars (editing bars) Created: 13/Jul/22  Updated: 27/Jul/22  Resolved: 19/Jul/22

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: 1.3.0
Fix Version/s: 1.3.0

Type: Bug Priority: Major
Reporter: Martin Haderka Assignee: Phong Le Quoc
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 3d 2.25h Time Spent: 3d 2.25h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File Screenshot 2022-07-13 at 14.43.40.png     Zip Archive test.zip     File vue_editor_no_green_bars.mp4    
Issue Links:
dependency
depends upon MGNLFE-233 Release and Publish Frontend Helpers ... Closed
relation
is related to MGNLFE-284 Angular sometimes does not show green... Closed
is related to MGNLFE-281 Review refresh calling Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLFE-276 Implement Sub-task Completed Phong Le Quoc  
MGNLFE-277 Review Sub-task Completed Canh Nguyen  
MGNLFE-278 PiQA Sub-task Closed Robert Šiška  
MGNLFE-279 QA Sub-task Closed Rishab Dhar  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Sprint: DevX 14
Story Points: 3

 Description   

Steps to reproduce

  1. Run project with @magnolia/vue-editor (you can use the vue minimal demo from Magnolia SPA Headless demo)
  2. use @magnolia/vue-editor version: 1.2.3-beta (if you're testing it on the spa minimal demo update the package.json and install
  3. run magnolia
  4. create and open page using the spa renderer
  5. run project with @magnolia/vue-editor (or the vue-minimal project)
  6. open Pages app

Expected results

  1. green bars for editing are visible
  2. add component, choose any you want, click save
  3. green bars will still be there

Actual results

  1. green bars are not visible after the page is opened (note: in some cases they may be)
  2. if they are not visible, refresh whole site and they will appear
  3. add a component, choose any you want, click save
  4. the green bars will disappear
  5. refresh whole site and they will appear

Workaround

  • refresh whole site
    or:
  • open Inspect Element on the iframe, run mgnlRefresh() command in console

Note

  • watch screen-recording with example


 Comments   
Comment by Christopher Zimmermann [ 13/Jul/22 ]

Thanks mhaderka . If you test with 1.2.2 is it working properly or showing same issue?

Comment by Martin Haderka [ 13/Jul/22 ]

czimmermann 1.2.1 and 1.2.2 are working fine. It just the 1.2.3-beta version.

Comment by Phong Le Quoc [ 17/Jul/22 ]

Root cause:

  • 1.2.2 code: always wait for 200 milliseconds before calling refresh at that time all comments are inserted usually.
  • 1.2.3-beta code: usually wait for 50 milliseconds (as soon as PageEditor script ready) before calling refresh at that time comments are not inserted

Solution:

  • call refresh method after insert comments (like Angular code)
Comment by Christopher Zimmermann [ 19/Jul/22 ]

plequoc great that you tested so extensively.

What does "always show for 20 tryings" mean?

Comment by Christopher Zimmermann [ 19/Jul/22 ]

So is the only remaining problem with Angular? And its only when there are only areas and no components?

Comment by Phong Le Quoc [ 19/Jul/22 ]

czimmermann 

 

Note: Updated comment above to be clearer and more information.

Comment by Christopher Zimmermann [ 19/Jul/22 ]

Thanks! So to confirm on angular page with "69 areas and 69 components" works reliably? 

Comment by Christopher Zimmermann [ 19/Jul/22 ]

I see this now in your comment above "the page with areas and components, and angular sample work fine when open them 20 times". So that answers my question.

Generated at Mon Feb 12 05:45:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.