[MGNLFE-30] react-editor Page should take a 'config' argument instead of 'componentMappings' Created: 17/Mar/20 Updated: 20/Apr/20 Resolved: 06/Apr/20 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Sang Ngo Huu |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d 6.5h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Documentation update required: |
Yes
|
||||||||
| Epic Link: | SPA Editor | ||||||||
| Sprint: | 6.2.1 Ramp-up 21 | ||||||||
| Story Points: | 3 | ||||||||
| Description |
|
The React <Page> component should take a 'config' parameter instead of 'componentMappings'. The config parameter is an object, and for now supports only one subproperty - 'componentMappings'. Update examples as well. Reason: The amount of configuration for the SPA libraries will definitely increase as we support additional features, such as personalization, multilanguage, AB-testing and so forth. It will save us and project developers trouble if we implement a 'config' argument now which can be the vehicle for the 'componentMappings' , and easily support further parameters later. This is a standard pattern for js libraries to accept all configuration in one JS object. |