[MGNLFE-300] Remove redundant variable "declaration" Created: 26/Jul/22 Updated: 23/Oct/23 Resolved: 19/Aug/22 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Phong Le Quoc | Assignee: | Phong Le Quoc |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 3.5h | Time Spent: | 3h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Epic Link: | Headless Phase 2 | |||||||||||||||||||||||||
| Sprint: | DevX 17 | |||||||||||||||||||||||||
| Story Points: | 0.5 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Description |
|
In abstract.component.ts, we declare @Input() content: object; openComment: string; closeComment: string; templateAnnotationSubscription: Subscription; templateDefinitionSubscription: Subscription; However, we also do in sub-classes In editable-page.component.ts templateAnnotationSubscription: Subscription; templateDefinitionSubscription: Subscription; ... @Input() content: object; In editable-component.component.ts templateAnnotationSubscription: Subscription; templateDefinitionSubscription: Subscription; These variables should be removed. They are redundant and make new devs confuse.
|