[MGNLFE-301] Remove templateAnnotationsUpdated Created: 26/Jul/22  Updated: 28/Jun/23

Status: Accepted
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Phong Le Quoc Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: needs-pm
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLFE-284 Angular sometimes does not show green... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: SPA Editor Backlog
Team: DeveloperX

 Description   

On Angular, depending on the way the sample is coded, templateAnnotationsUpdated might be needed. However, it adds complexity to the code without any big benefit.

If "content" and "template-annotations" are loaded (or templateAnnotations are loaded firstly) and then do others, templateAnnotationsUpdated is redundant. (https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/158/diff#samples/angular-sample/src/app/root.component.ts). In addition, React and Vue load both firstly also.

Pros:

  • Reduce complexity
  • Consistent with Vue and React

Cons:

  • Need asking customers to verify their code
  • May break customers' code on a rare occasion in edit mode if their code have not updated yet

 

B.T.W, we might think about providing a loading method in the editors for loading content and templateAnnotations instead of SPA do.


Generated at Mon Feb 12 05:46:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.