[MGNLFE-301] Remove templateAnnotationsUpdated Created: 26/Jul/22 Updated: 28/Jun/23 |
|
| Status: | Accepted |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Phong Le Quoc | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | needs-pm | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | SPA Editor Backlog | ||||||||
| Team: | |||||||||
| Description |
|
On Angular, depending on the way the sample is coded, templateAnnotationsUpdated might be needed. However, it adds complexity to the code without any big benefit. If "content" and "template-annotations" are loaded (or templateAnnotations are loaded firstly) and then do others, templateAnnotationsUpdated is redundant. (https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/158/diff#samples/angular-sample/src/app/root.component.ts). In addition, React and Vue load both firstly also. Pros:
Cons:
B.T.W, we might think about providing a loading method in the editors for loading content and templateAnnotations instead of SPA do. |