[MGNLFE-333] Should not render close comment tag Created: 05/Oct/22 Updated: 23/Oct/23 Resolved: 12/Oct/22 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | 1.3.0 |
| Fix Version/s: | 1.3.1 |
| Type: | Bug | Priority: | Major |
| Reporter: | Phong Le Quoc | Assignee: | Dai Ha |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 0.25d | Time Spent: | 0.25d |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
|||||||||||||||||||||||||
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Epic Link: | SPA Maintenance | |||||||||||||||||||||||||
| Sprint: | DevX 21 | |||||||||||||||||||||||||
| Story Points: | 3 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Description |
|
When there is no template-annotation info, the close comment tag is still rendered. It should be the reason why green bars are not shown for the others. |
| Comments |
| Comment by Phong Le Quoc [ 05/Oct/22 ] |
|
Current EditableComponent code
<EditableComment annotation={this.getAnnotation()} callback={this.onReady} />
{component}
<EditableComment annotation={this.constants.CLOSED_COMPONENT_COMMENT} />
consider to use the format bellow if posible
<EditableComment openComment={this.getAnnotation()} callback={this.onReady} closeComment={this.constants.CLOSED_COMPONENT_COMMENT}>
{component}
</EditableComment>
or even better
<EditableComment annotation={this.getAnnotation()} callback={this.onReady}>
{component}
</EditableComment>
|