[MGNLFE-351] Strange Angular project structure Created: 13/Oct/22  Updated: 23/Oct/23

Status: Open
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Phong Le Quoc Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLFE-352 Upgrade Lerna Accepted
is related to MGNLFE-350 Apply the same code format and linter... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: SPA Maintenance
Team: DeveloperX

 Description   

Why is Angular project organized as current? It should be re-organized the same the others if possible, otherwise, some comment should be written down in README or NOTE.

When trying a tool from lerna

Skipping project found at packages/angular-editor/dist/angular-editor since project @magnolia/angular-editor already exists at packages/angular-editor! Specify a unique name for the project to allow Nx to differentiate between the two projects.
Skipping project found at packages/angular-editor/projects/angular-editor since project @magnolia/angular-editor already exists at packages/angular-editor! Specify a unique name for the project to allow Nx to differentiate between the two projects.
Skipping project found at packages/angular-editor/dist/angular-editor since project @magnolia/angular-editor already exists at packages/angular-editor! Specify a unique name for the project to allow Nx to differentiate between the two projects.
Skipping project found at packages/angular-editor/projects/angular-editor since project @magnolia/angular-editor already exists at packages/angular-editor! Specify a unique name for the project to allow Nx to differentiate between the two projects.
 

 



 Comments   
Comment by Christopher Zimmermann [ 13/Oct/22 ]

My impression is that it is the format created by the Angular CLI. rsiska  do you know?

Comment by Canh Nguyen [ 14/Oct/22 ]

Yes, Angular project structure is created by the Angular CLI.

Comment by Phong Le Quoc [ 11/Jan/23 ]

Related documents:

Comment by Phong Le Quoc [ 11/Jan/23 ]

At least, we should change name in packages/angular-editor/package.json or packages/angular-editor/projects/package.json

Comment by Phong Le Quoc [ 15/Feb/23 ]

With duplicated name 

npm run build 

is failed (Lerna). Therefore, we need to declare template-annotations dependent in angular-sample.

Comment by Christopher Zimmermann [ 15/Feb/23 ]

Current structure is really confusing. Seems like you should not need such a nested project.

Generated at Mon Feb 12 05:46:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.