[MGNLFE-371] Review all components' parameters to assess if it is optional or required Created: 17/Nov/22  Updated: 23/Oct/23  Resolved: 10/Jan/23

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: 1.3.1
Fix Version/s: 1.3.2

Type: Bug Priority: Neutral
Reporter: Canh Nguyen Assignee: Javier Benito
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
dependency
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLFE-379 Implement fix Technical task Completed Javier Benito  
MGNLFE-380 Review Technical task Completed Robert Šiška  
MGNLFE-381 Pre-Integration QA Technical task Completed Robert Šiška  
MGNLFE-382 QA Technical task Completed Phong Le Quoc  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: SPA Maintenance
Sprint: DevX 27, DevX 28
Story Points: 2
Team: DeveloperX
Work Started:

 Description   

There's an issue reported here https://magnolia-cms.slack.com/archives/CHTPDA2NA/p1668596272059899 

We should review all components in frontend helpers and update accordingly.


On 1.3.1 we are seeing errors in the browser console. These should not happen.

From Bartosz: FYI in dev mode in next js we get this:
Warning: Failed prop type: The prop `annotation` is marked as required in `EditableComment`, but its value is `undefined`.
From Scot:  Anybody else getting
Warning: Failed prop type: The prop `annotation` is marked as required in `EditableComment`, but its value is `undefined`.
Only happens outside of Magnolia, where the "templateAnnotations" is an empty object. Not a big deal, just throws ugly stack traces.



 Comments   
Comment by Canh Nguyen [ 28/Nov/22 ]

This ticket needs to be tested on SSR.

Generated at Mon Feb 12 05:46:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.