[MGNLFE-372] Creating component variant breaks editor JS Created: 17/Nov/22 Updated: 23/Oct/23 Resolved: 31/Jan/23 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | 1.3.1 |
| Fix Version/s: | 1.3.2 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Tobias Kerschbaum | Assignee: | Canh Nguyen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 3d 3h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: | |||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Epic Link: | SPA Maintenance | ||||||||||||||||
| Team: | |||||||||||||||||
| Work Started: | |||||||||||||||||
| Description |
| Comments |
| Comment by Christopher Zimmermann [ 17/Nov/22 ] |
|
Which framework? React, Vue, Angular? |
| Comment by Bartosz Staryga [ 17/Nov/22 ] |
|
We have noticed it on Next.js based project: insurance demo. Rolling back to 1.3.0 makes it work again. |
| Comment by Christopher Zimmermann [ 24/Nov/22 ] |
|
oanh.thai verified that the feature does work on the react-sample project which is a part of the frontend-helpers project.
|
| Comment by Christopher Zimmermann [ 23/Jan/23 ] |
|
Reopening as developer (bstaryga ) still has the problem on project. bstaryga Is there a project that the team can use to reproduce the issue? Does it need to be SSR? |
| Comment by Bartosz Staryga [ 23/Jan/23 ] |
|
The error is thrown here variant is undefined and JS can not perform replace on it. czimmermann we reproduce it on our demo instance. ...Question |
| Comment by Canh Nguyen [ 27/Jan/23 ] |
|
Hi bstaryga , What Magnolia version are you using? |
| Comment by Bartosz Staryga [ 27/Jan/23 ] |
|
We are on `6.2.26`. |
| Comment by Christopher Zimmermann [ 31/Jan/23 ] |
|
Closing this ticket as the "new problem" was caused by incorrect usage of the system. To cover this error and log a warning we introduce more checks in the code. We will also improve documentation of how to use SPA editor on another workspace - including with personalizaion. |