[MGNLFE-394] preview tab button does not work Created: 10/Jan/23  Updated: 13/Jan/23  Resolved: 13/Jan/23

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: 1.3.1
Fix Version/s: 1.3.2

Type: Bug Priority: Neutral
Reporter: Sergio Marino Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
causality
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLFE-399 Implementation Sub-task Completed Robert Šiška  
MGNLFE-400 Review Sub-task Completed Phong Le Quoc  
MGNLFE-401 Pre-Integration QA Sub-task Completed Phong Le Quoc  
MGNLFE-402 QA Sub-task Completed Canh Nguyen  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Epic Link: SPA Editor Backlog
Sprint: DevX 28
Team: DeveloperX
Work Started:

 Description   

Please read comments from customer:

after bisecting frontend-helpers master branch I found the actual source of our issue - which underlines my initial guess, that magnolia is not notified correctly about change on the frontend.

I found, that our problem arises from frontend-helpers#5528322c51017edc45fab032ebfd1db93bab8830 (before react-editor works fine).

My guess is, that a regression was introduced by removing the line packages/react-editor/src/component/EditablePage/EditablePage.js?f=52 with statement EditorContextHelper.onFrameReady().

Somehow, this method is supposed to inform magnolia about some form of change when the page is running in an iframe, which then is triggering Magnolia to update the preview button with a location url.

After re-adding the code line to the mentioned commit, our problem does not occur anymore. I got the same result, when re-adding the code to the latest commit in branch master.

Maybe you can bring some light into the matter, if this is the correct reasoning, and why this does not happen when running an external SPA?


Generated at Mon Feb 12 05:47:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.