[MGNLFE-403] Remove duplicated onFrameReady call Created: 13/Jan/23 Updated: 23/Oct/23 |
|
| Status: | Open |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Phong Le Quoc | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | SPA Maintenance | ||||||||
| Team: | |||||||||
| Description |
|
This PR removes the duplicated call https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/156/overview. However, it made a side effect. Therefore, the other PR rollback this change https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/183/overview. So we should verify this again to see if we can remove the duplicated call or not and comment some if it is impossible.
Robert Šiška's note: In external SPA, the onFrameReady is called after the PageEditorBridge receives initialization message from the server. However, on magnolia-hosted SPAs this is never called. This change means, that the function is called twice on external SPAs (first when the page is mounted, and second in the PageEditorBridge). This is not ideal, but doesn't seem to cause an issues. Please try on all three frameworks (external & SPA) to see if there are any side-effects. |
| Comments |
| Comment by Robert Šiška [ 13/Jan/23 ] |
|
Since we're planning to deprecate the "magnolia-hosted" way of deployment (hopefully) soon in the future, I think we can safely remove it after that happens. |