[MGNLFE-44] Angular - components do not rerender on props change Created: 04/May/20  Updated: 11/May/20  Resolved: 08/May/20

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: 1.0.0
Fix Version/s: None

Type: Bug Priority: Blocker
Reporter: Bartosz Staryga Assignee: Canh Nguyen
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.25d
Original Estimate: Not Specified

Issue Links:
Cloners
clones MGNLFE-40 Components in @magnolia/react-editor ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: SPA Editor
Sprint: HL & LD 2
Story Points: 3

 Description   

Reported against react in MGNLFE-40; check angular as well.

All components inĀ @magnolia/react-editor are classes so they do not rerender on new props.
Hence when new page is fetched and new content is passed to Page component id does not update.

It blocks the SPA behaviour.

Please make all the components a stateless ones, as we do not need them to be full blow classes, and stateless ones will fix the issue.



 Comments   
Comment by Canh Nguyen [ 08/May/20 ]

Angular-editor is working correctly when props change.

Generated at Mon Feb 12 05:43:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.