[MGNLFE-52] For <base href> inside magnolia the language is ignored Created: 25/May/20  Updated: 25/May/20

Status: Open
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Bartosz Staryga Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

when setting <base href>  inside magnolia the language is ignored.
so e.g. my iframe is in default language then:
iframe src is: /magnoliaAuthor/angular-minimal.html
and base is: <base href="/magnoliaAuthor/angular-minimal"
When I switch to german then:
iframe src is: /magnoliaAuthor/de/angular-minimal.html
and base is: <base href="/magnoliaAuthor/angular-minimal">  which is wrong as it should be: <base href="/magnoliaAuthor/de/angular-minimal">

The workaround is this: https://git.magnolia-cms.com/projects/DEMOS/repos/minimal-headless-spa-demos/browse/spa/angular-minimal/src/app/app.module.ts#53
Which imho we should make as required step and stop Magnolia adding that element.
Why? Because when we use the languages in magnolia this base needs to be defined dynamically, not on a build level, as we do not want to have separate build for separate languages...


Generated at Mon Feb 12 05:43:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.