[MGNLFE-526] eslint config of angular-editor is wrong Created: 21/Jun/23 Updated: 26/Jul/23 Resolved: 28/Jun/23 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.4 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Phong Le Quoc | Assignee: | Phong Le Quoc |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 7.75h | Time Spent: | 7.75h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Epic Link: | SPA Editor Backlog | |||||||||||||||||||||||||
| Sprint: | DevX 40, DevX 41, DevX 42 | |||||||||||||||||||||||||
| Story Points: | 2 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Approved: |
Yes
|
| Description |
|
When running npm run lint, there is an error for angular-editor. Should be changed to "project": [ "./projects/angular-editor/tsconfig.lib.json", "./projects/angular-editor/tsconfig.spec.json" ], in packages/angular-editor/projects/angular-editor/.eslint.json. However, IntelliJ will show an error (IntelliJ is wrong) when open .ts files in angular-editor. We should find a way that is accepted by Lerna and IntelliJ also. If satisfy both takes time, we could go with Lerna Note: 1. The code generated by Angular does not contain "project" attributes in .eslint.json files of angular editors. In addition, tried to remove the attributes and there are no errors, however, we should find out if it is suitable for our project or not. 2. In IntelliJ, we can config eslint working directory point to ./packages/angular-editor to eliminate the error, however, we have some projects so it could be have many values. Reference: https://youtrack.jetbrains.com/issue/WEB-47135/Allow-to-configure-working-directory-for-ESLint-process |
| Comments |
| Comment by Phong Le Quoc [ 23/Jun/23 ] |
|
Using glob pattern to resolve issue with IntelliJ https://eslint.org/docs/latest/use/configure/configuration-files |