[MGNLFE-56] Edit Component action is enabled even when component has no dialog Created: 09/Jun/20  Updated: 08/Sep/20  Resolved: 08/Sep/20

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: 1.0.2
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Robert Šiška Assignee: Robert Šiška
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by MGNLFE-12 DOC: SPA can get its content from a M... Closed
is caused by MGNLFE-58 Allow using dialog at area level Closed
Relates
relates to MGNLFE-66 SPA Editor: Areas in Magnolia show a ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: SPA Editor
Story Points: 2

 Description   

While the pencil icon on the green bar is not shown, the Edit Component action is not disabled.

 

This seems to be caused by `dialog=""` in HTML comment annotation.

 

Consider if it should be fixed in Page Editor, or if we should just prevent generation of empty dialog argument in template-annotions library.


Generated at Mon Feb 12 05:43:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.