[MGNLFE-563] Refactor EditableComment (interactivity component) Created: 05/Jul/23  Updated: 17/Aug/23  Resolved: 11/Aug/23

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: None
Fix Version/s: 1.6

Type: Story Priority: Neutral
Reporter: Oanh Thai Hoang Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 7d 4.25h Time Spent: 4d 6.75h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLFE-617 Variants menu and green bar position ... Closed
dependency
is depended upon by MGNLFE-565 Refactor EditableArea Closed
is depended upon by MGNLFE-566 Refactor EditablePage Closed
is depended upon by MGNLFE-567 Refactor EditableComponent Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLFE-580 Implement Sub-task Completed Oanh Thai Hoang  
MGNLFE-581 Review Sub-task Completed Robert Šiška  
MGNLFE-582 piQA Sub-task Completed Phong Le Quoc  
MGNLFE-583 QA Sub-task Completed Robert Šiška  
MGNLFE-588 Still check while sometime does not r... Sub-task Closed Oanh Thai Hoang  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: React RSC
Sprint: DevX 42, DevX 43, DevX 44
Story Points: 5
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

EditableComment (interactivity component)

  • alwaysRender props should pass from parent component. Detect alwaysRender via #magnoliaContext.isMagnolia from EditorContextHelper
  • Add 'use client' in top of file ( react will ignore it by default so maybe no harm at all)

 

Ref code in proposal PR: https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/220/diff#samples/next-js-13-with-react-editor-new/packages/react-wrap-client-component-typescript/src/WrapperEditableComment.tsx


Generated at Mon Feb 12 05:48:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.