[MGNLFE-57] Allow more control on the HTML Comment generation Created: 23/Jun/20  Updated: 24/Nov/20  Resolved: 24/Nov/20

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: Template Annotations
Affects Version/s: 1.0.4
Fix Version/s: None

Type: Improvement Priority: Critical
Reporter: Adrien Manzoni Assignee: Unassigned
Resolution: Obsolete Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing PAGES-352 Provide endpoint for template annotat... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: SPA Editor

 Description   

In the HTML comment used to render the green bars in the page editor, we lack the possibility to add the icons and styles elements attributes used by live-copy for instance.

The current template annotation handler:

https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/browse/packages/template-annotations/src/service/TemplateAnnotations.js

 

The live-copy custom element attribute:

https://git.magnolia-cms.com/projects/ADDON/repos/live-copy/browse/src/main/resources/livecopy/decorations/templating/config.pageEditorAttributes.component.icons.yaml

 

To summarize, live-copy use 2 attributes of the current component JCR node to create 2 additional attributes in the component edition bar (icons and styles). Currently we have no way to set those attribute properly by using the SPA renderer.



 Comments   
Comment by Simon Lutz [ 25/Aug/20 ]

Live copy for 6.2 is about to be available - hence this ticket's priority is increased. Moved it to SPA Editor Phase 1 and added to backlog.

Generated at Mon Feb 12 05:43:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.